-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hijack links clicked from within JupyterLab #8
Comments
@ian-r-rose @blink1073 you guys have any thoughts about this? |
@timkpaine I think you should be able to create a new |
One better, we could make Then this plugin could provide those without the user needing to disable the core plugin. |
I think im going to close this. Its a good thought, but in the "real world" stuff has been way more difficult. As a simple example, id say 99% of jupyterlab users run without ssl, and 99% of the websites they access will run with ssl, meaning 99% of the links we want to hijack will pass through the jupyterlab_iframe proxy which make life super difficult. Same deal for websites not allowing iframe embedding (e.g. google.com), websites with cors issues, etc. The user experience would just be terrible. |
For a notebook with a link to some reference documentation it would be nice if by default the web page was opened in
jupyterlab_iframe
so you could use the powerful phosphor layout capabilities to place it where you want rather than have it open in a new tab.Ctrl-click could then as usual open in a new tab and there could be a context menu item for that too.
The text was updated successfully, but these errors were encountered: