Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make openTextgrid() and save() parameters manditory #27

Closed
timmahrt opened this issue Apr 5, 2021 · 4 comments
Closed

Make openTextgrid() and save() parameters manditory #27

timmahrt opened this issue Apr 5, 2021 · 4 comments

Comments

@timmahrt
Copy link
Owner

timmahrt commented Apr 5, 2021

New features are added in a backwards compatible way--they are given default values--but this has obscured some important functionality.

These parameters should be changed to be required so that users are forced to make mindful decisions about how praatio manipulates their data.

@timmahrt
Copy link
Owner Author

timmahrt commented Aug 7, 2021

This is in Praatio 5.0 now.

textgrid.openTextgrid() had an optional parameter readRaw. This was renamed to includeEmptyIntervals and made required.

For textgrid instance tg, tg.save there were two optional arguments format and ignoreBlankSpaces. ignoreBlankSpaces was changed to includeBlankSpaces (the variable was renamed and the logic flipped in the code).

Both parameters were made required.

@timmahrt
Copy link
Owner Author

timmahrt commented Aug 7, 2021

Here are examples of the new interface

textgrid.openTextgrid(
  fn=name,
  includeEmptyIntervals=False
)
tg.save(
  fn=name,
  format= "short_textgrid",
  includeBlankSpaces= "false"
)

@timmahrt
Copy link
Owner Author

timmahrt commented Aug 7, 2021

I will close this issue once Praatio 5.0 is released.

@timmahrt
Copy link
Owner Author

timmahrt commented Aug 9, 2021

Praatio 5.0 is now released!

@timmahrt timmahrt closed this as completed Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant