Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinching on mobile looks off on long images #513

Closed
rmatec opened this issue Sep 22, 2020 · 1 comment
Closed

Pinching on mobile looks off on long images #513

rmatec opened this issue Sep 22, 2020 · 1 comment

Comments

@rmatec
Copy link

rmatec commented Sep 22, 2020

Describe the bug

The pinching on mobile looks off when the image backing Panzoom is long. It appears as though the focal point is at the bottom of the image instead of being between the fingers.

Your environment

  • Version of panzoom -> 4.3.2
  • Browser and browser version -> Safari 14 on iOS 14 / Chrome on Android 10

Expected behavior

Pinching on mobile zooms in to the correct focal point (between the fingers)

Actual behavior

Pinching on mobile zooms in to the wrong focal point.

Steps to reproduce

Check this.
https://jsbin.com/qasezevicu/edit?html,js,output

@timmywil
Copy link
Owner

timmywil commented Oct 1, 2020

After some investigation, this is actually the same issue as #512. It will be fixed when I add the ability to center on the panzoom element rather than the viewport. You can confirm this by setting a height on the parent and centering the image vertically https://jsbin.com/nuyonijugu/1/edit?html,css,js,output

@timmywil timmywil closed this as completed Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants