Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeyStoreInputStream never close #13

Closed
GoogleCodeExporter opened this issue Apr 23, 2015 · 2 comments
Closed

KeyStoreInputStream never close #13

GoogleCodeExporter opened this issue Apr 23, 2015 · 2 comments

Comments

@GoogleCodeExporter
Copy link

In back.SSLCOnnectionHelper, the keystoreInputStream parameter of the 
constructor may be 
closed no ?

code concerned :

    public SSLConnectionHelper(String appleHost, int applePort, InputStream 
keyStoreInputStream, String keyStorePass, String keystoreType) throws 
KeyStoreException, 
CertificateException, NoSuchAlgorithmException, NoSuchProviderException, 
IOException {
        logger.debug( "Instantiate SSLConnectionHelper with Keystore as InputStream" );
        this.appleHost = appleHost;
        this.applePort = applePort;
        this.keyStorePass = keyStorePass;

        // Load the Keystore
        this.keyStore = KeyStore.getInstance(keystoreType, "BC");
        this.keyStore.load( keyStoreInputStream, this.keyStorePass.toCharArray() );
    }

Original issue reported on code.google.com by desa.e...@gmail.com on 23 Mar 2010 at 10:50

@GoogleCodeExporter
Copy link
Author

I'm not sure what you are asking...

Should we close the inputstream? 
seems like a bad idea.. what if the input stream is used for other things...

or check that the inputstream exists?
If there is no inputstream, then that would raise an exception...

Original comment by idbill.p...@gmail.com on 25 Mar 2010 at 5:10

  • Changed state: Started

@GoogleCodeExporter
Copy link
Author

Original comment by idbill.p...@gmail.com on 26 Mar 2010 at 9:35

  • Changed state: WontFix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant