Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default prefix conflicts with medium size #3

Open
timobrembeck opened this issue Sep 30, 2022 · 0 comments
Open

Default prefix conflicts with medium size #3

timobrembeck opened this issue Sep 30, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@timobrembeck
Copy link
Owner

When using the option $fp-prepend: true; with the default prefix "fp", the medium size fp-md conflicts with the flag for Moldova fp-md. This means, e.g. the following:

<span class="fp fp-de"></span> <span class="fp fp-md fp-de"></span> <span class="fp fp-lg fp-de"></span>

renders to:

118176474-bf406e00-b431-11eb-850b-ec69c8efa214

And

<span class="fp fp-md"></span> <span class="fp fp-md fp-md"></span> <span class="fp fp-lg fp-md"></span>

renders to:

118195013-af815380-b44a-11eb-976e-8e3593bc44c7

So I suggest to use either a different suffix for the medium size or set the default prefix to a different value.

Also, a quick workaround for the first problem would be to move "md" to the beginning of the default $fp-countries list so that any other flag classes can overwrite the background-image property since the classes are defined later in the resulting css file.

(I'm aware that it's possible to change the value for $fp-prefix manually, but I still think the default config should make sense.)

I first opened this ticket in the upstream repository (jackiboy/flagpack#14), but since this is no longer maintained and the problem persists on my fork, I copied it into this repository as well.

@timobrembeck timobrembeck added the bug Something isn't working label Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant