Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animation after TabPress seems to have too much delay #7

Closed
timomeh opened this issue Feb 26, 2017 · 5 comments
Closed

Animation after TabPress seems to have too much delay #7

timomeh opened this issue Feb 26, 2017 · 5 comments

Comments

@timomeh
Copy link
Owner

timomeh commented Feb 26, 2017

No description provided.

@timomeh
Copy link
Owner Author

timomeh commented Feb 26, 2017

Fixed with #2

(I'm speaking about the growing tab resp. the movement of icon) I think the delay of 5 Frames from the Demo-Video in the Guidelines is just caused by the easeIn. No real delay needed here.

@timomeh timomeh closed this as completed Feb 26, 2017
@emileNetter
Copy link

Hi ! First of all thank you for this great RN component 🥇. But I still have a slight delay when pressing a new tab or swiping between the tabs.

giphy

Any advice ?
Thanks

@timomeh
Copy link
Owner Author

timomeh commented May 20, 2017

Are you using react-navigation? If so, then it seems like react-navigation doesn't update the state to the bottom navigation soon enough, if you swipe. I actually never tested this component together with the swipe-gesture of react-navigation.
Maybe test react-navigation's own TabBar. If it behaves the same way then it's surely an issue on their side. If not, then I'll have to adjust something. My react-navigation implementation isn't something official supported on their side, I made it when react-navigation was still in an early beta.

You could also consider disabling the slide-gesture in react-navigation. The material guidelines for the bottom navigation behaivour advise against using the swipe-gesture for changing the tab.

If there's a noticeable delay between pressing the tab and the actual change of the screen, then this looks like a new bug which needs to be fixed. If so, please open a new issue.

(Note: This issue originally didn't deal with this particular thing. It was just that only the growing-animation of the icon was a few frames too late.)

@emileNetter
Copy link

emileNetter commented May 22, 2017

Yes I'm using the new react-navigation and it's the same delay if I swipe or if I tap. I'll try disabling the swipe gesture and let you know if that changes anything ! Ohterwise I will open a new issue.

P.S : How would you disable the slide gesture ?

@timomeh
Copy link
Owner Author

timomeh commented May 30, 2017

@emileNetter Sorry for taking so long, guess I need a better way to keep track of pending comments.

Probably you figured it out by now, in case not: theres a swipeEnabled key in TabNavigatorConfig.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants