v1.0 – Cleanup, rewrite and long-awaited customizability #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because renderprops and PureComponents aren't that close friends and I don't want to have weird side effects. See https://reactjs.org/docs/render-props.html#be-careful-when-using-render-props-with-reactpurecomponent
This was referenced Mar 6, 2018
Closed
Closed
|
can we merge this? works perfect and will fix this weird bug #75 |
|
@santomegonzalo Nice to hear that you used the new version and it worked. I'll write more usage docs later this day and then merge it. I don't want to merge it without at least a bit more documentation. |
|
@timomeh any news about this PR? because it's blocking a lot. |
|
I'm currently quite busy, in the meantime you should be able to use this PR in your package.json dependencies with |
Yeah, some people browse the docs in the downloaded package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Cleanup of the old codebase.
Because the old codebase is really messy (what was I thinking?), this is basically is a rewrite of the whole Bottom Navigation. It will also include a large amount of customizability.
Version 1.0 will have breaking changes. It won't immediately be released with a Component for react-navigation. However, react-navigation support will be the next step.
Tasks
General
Background Ripple AnimationBottomNavigationTab ListTabControlled ComponentPress Ripple AnimationFlow Type DefinitionsTypeScript Type DefinitionsTest everythingBottomNavigationTabListPress FeedbacksTabsBadgeAdd CIUpdate READMESupport react-native-webCreate DocsPluggable Components
Icon TabIcon+Label TabShifting TabBadge