Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IsPrivate rule (and some other) do not support CallbackQueryCute even when the latter must be supported #83

Closed
2 tasks done
prostomarkeloff opened this issue Jun 17, 2024 · 2 comments
Assignees
Labels
bug Something isn't working fix Fix something

Comments

@prostomarkeloff
Copy link
Contributor

prostomarkeloff commented Jun 17, 2024

⚪️ Checklist ⚪️

  • ❕ I'm sure this is a bug in the framework
  • 🟢 I have the latest version of the framework installed 🟢

✏️ Description ✏️

IsPrivate rule (and some other) do not support CallbackQueryCute even when the latter must be supported.

IsPrivate rule checks if chat_type is private. Message does support it and IsPrivate inherits from MessageRule that doesn't let anything but Message go there. There should be something like CallbackQueryOrMessageRule, adapter of which supports both Message and CallbackQuery

@prostomarkeloff prostomarkeloff added bug Something isn't working fix Fix something labels Jun 17, 2024
@timoniq
Copy link
Owner

timoniq commented Jun 17, 2024

CallbackQueryOrMessageRule -> probably SourceAdapter

also a node might be created for compositional approach (PrivateSource / PublicSource)

@luwqz1
Copy link
Collaborator

luwqz1 commented Jun 17, 2024

@luwqz1 luwqz1 closed this as completed in 4b00ebd Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fix Fix something
Projects
None yet
Development

No branches or pull requests

3 participants