isort and pre-commit - not only Python files are processed

[jugmac00]

I was using pre-commit (as in pre-commit.com) as follows:

  - repo: https://github.com/timothycrosley/isort
    rev: 4.3.21 
    hooks:
      - id: isort
        args: [--filter-files]

This worked perfectly.

Once I updated to 4.3.21-2, not only Python files, but also json, rst, po, mako, html, pot and cfg files were touched and modified by isort.

In the https://github.com/timothycrosley/isort/blob/develop/CHANGELOG.md I could not find an entry for 4.3.21-2 at all.

My current workaround is following config:

  - repo: https://github.com/timothycrosley/isort
    rev: 4.3.21-2
    hooks:
    - id: isort
      args: [--filter-files]
      files: \.py$

I am pretty new to both pre-commit and isort - so maybe I miss something.

Maybe I miss the point, but why would I want to use isort on a json or a po (translation) file?

P.S.: @asottiles pre-commits version is 2.0.1.

[asottile]

that is very strange indeed -- the types: [python] should be limiting to python files

can you run identify-cli on some of the files that were changed for me?

it's also possible you're using a really old pre-commit which doensn't understand types -- but it doesn't look like that?

[jugmac00]

Update
I guess I tracked the problem down - .pre-commit-hook.yaml is different for 4.3.21.zip (ok) and 4.3.21-2.zip (borked).

4.3.21

-   id: isort
    name: isort
    entry: isort
    require_serial: true
    language: python
    types: [python]

4.3.21-2

-   id: isort
    name: isort
    entry: isort
    require_serial: true
    additional_dependencies: []
    language: python

https://github.com/timothycrosley/isort/archive/4.3.21.zip
https://github.com/timothycrosley/isort/archive/4.3.21-2.zip

[asottile]

ah that's what it is, the configuration for 4.3.21-2 is busted: https://github.com/timothycrosley/isort/blob/4.3.21-2/.pre-commit-hooks.yaml#L6

[jugmac00]

Well, at least my .po files are now sorted! :-)