Skip to content
This repository has been archived by the owner on Feb 24, 2019. It is now read-only.

Remove universal=1 from wheel config. #41

Closed
apollo13 opened this issue May 1, 2015 · 3 comments
Closed

Remove universal=1 from wheel config. #41

apollo13 opened this issue May 1, 2015 · 3 comments
Labels

Comments

@apollo13
Copy link

apollo13 commented May 1, 2015

https://github.com/timothycrosley/pies/blob/develop/setup.cfg#L2 is wrong and should be false (or removed) for this package. The reason is simple: install_requires changes based on whether python2 or python3 is used to execute setup.py -- this will have the resulting wheel contain requirements which are wrong depending which python version you use to install it.

@dstufft
Copy link

dstufft commented May 1, 2015

You could also just use enviornment markers to have a conditional dependencies:

I think you just need to add:

extras_require={
    ":python_version == 2.6 or python_version == 2.7": ["enum34"],
}

to your setup.py.

@timothycrosley
Copy link
Owner

@apollo13 thanks for reporting this issue! And @dstufft thanks for your insight on the best way to resolve it. I've just released version 2.6.5 which should use this approach to correctly build the universal wheel.

Thanks!

~Timothy

@apollo13
Copy link
Author

apollo13 commented May 7, 2015

@timothycrosley The wheel still has:

Requires: pies2overrides
Requires: enum34
Requires-Dist: pies2overrides
Requires-Dist: enum34

I think you can should drop those two from install_requires completely.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants