Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue on all my modules's methods #10

Closed
kootenpv opened this issue Aug 27, 2019 · 3 comments
Closed

Issue on all my modules's methods #10

kootenpv opened this issue Aug 27, 2019 · 3 comments
Labels
bug Something isn't working

Comments

@kootenpv
Copy link

kootenpv commented Aug 27, 2019

Tried this with a clone of https://github.com/kootenpv/access_points (one of my simplest repos) and the result is visible in the screenshot: something goes wrong with the methods?

https://i.imgur.com/FVYV9u5.png

Quick link to the source code visible in the screenshot: https://github.com/kootenpv/access_points/blob/master/access_points/__init__.py#L164

@Pebaz
Copy link

Pebaz commented Aug 28, 2019

I've spotted another incongruency here.

All the function names are stripped.

@timothycrosley
Copy link
Owner

@Pebaz that was actually a stylistic decision (if you look at the right above the def you see the function name so it felt weird to repeat it) Still I could see how that could be confusing, and am open to other suggestions.

@timothycrosley timothycrosley added the bug Something isn't working label Aug 29, 2019
@timothycrosley
Copy link
Owner

Thank you for alerting me to this issue!
This should now be resolved in release 1.1.0: https://timothycrosley.github.io/portray/CHANGELOG/#changelog

Thanks!

~Timothy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants