Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google-News-Sitemap xmltags missing #4

Open
GoogleCodeExporter opened this issue Feb 6, 2016 · 7 comments
Open

Google-News-Sitemap xmltags missing #4

GoogleCodeExporter opened this issue Feb 6, 2016 · 7 comments

Comments

@GoogleCodeExporter
Copy link

Its currently not possible to create a complete
google-news-sitemap with this tool.
Tags like 
"title" or "publication" are important and missing.

Original issue reported on code.google.com by jens.gro...@googlemail.com on 27 Jan 2010 at 2:51

@GoogleCodeExporter
Copy link
Author

I noticed this problem as well when I was looking at the javadoc.  This is more 
than
just a bug since you cannot even create a valid news sitemap as the previous 
poster
said.  This means the classes related to google news sitemaps are useless as 
is. 
Please address this because you cannot say that your tool supports this type of
sitemap when it actually does not. 

Original comment by feedb...@mysask.com on 13 Apr 2010 at 9:58

@GoogleCodeExporter
Copy link
Author

This does appear to be a real problem.  Unfortunately, I don't use News 
Sitemaps, so
I may not be able to fix this in a timely manner.  Patches welcome.

Original comment by DanFabul...@gmail.com on 14 Apr 2010 at 1:13

  • Changed state: Accepted
  • Added labels: Priority-High
  • Removed labels: Priority-Medium

@GoogleCodeExporter
Copy link
Author

OK I have created a patch to fix this.  What is the process to submit the patch?

I have attached a zip file containing the code.

Here is a quick list of the changes:

Added classes:
Acess - enum class for valid access values in the google news sitemap
Genre - enum class for valid genre values in the google news sitemap

Changes classes:
GoogleNewsSitemapUrl - add new fields for new tags, with getter methods and 
setters 
in the Options class
GoogleNewsSitemapGenerator - changed rendered to render new tags
GoogleNewsSitemapUrl - added new test "testFullOptions" to test all new tags

Note: the changes should not affect the behaviour of any existing code that 
uses 
these classes in any way



Original comment by feedb...@mysask.com on 14 Apr 2010 at 11:06

Attachments:

@GoogleCodeExporter
Copy link
Author

Thanks for posting this. I think that these new additions to Google's algorithm 
will make online the <a href="http://www.freesitemapsubmit.com/">XML sitemap 
generator</a> tools even more important.

Original comment by theyoudo...@gmail.com on 9 May 2011 at 8:22

@GoogleCodeExporter
Copy link
Author

Any chance the patch will be accepted?

Original comment by nflcs...@gmail.com on 8 Nov 2012 at 5:35

@GoogleCodeExporter
Copy link
Author

I noticed that this issue is still not resolved and the patch has not been 
accepted.  The News Sitemap is unusable without it, any chance this can still 
be accepted?

Original comment by atl...@gmail.com on 14 Oct 2014 at 4:33

@GoogleCodeExporter
Copy link
Author

Could you please open a pull request with the fix at 
https://github.com/dfabulich/sitemapgen4j ?

Original comment by m.k...@irregular.at on 20 Mar 2015 at 10:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant