Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legacy mode from wavelet #225

Closed
Sensex00 opened this issue Jun 19, 2024 · 1 comment
Closed

Legacy mode from wavelet #225

Sensex00 opened this issue Jun 19, 2024 · 1 comment

Comments

@Sensex00
Copy link

I think we should introduce legacy mode in the app apart from shizuku it will be great for users both old and new to quickly get this app working
It will come in handy maybe some features would not usable but it's not a bad feature to have have
Apart from dump permission

@timschneeb
Copy link
Owner

timschneeb commented Jun 27, 2024

As mentioned in the README:

Regular rootless audio effect apps on the Play Store all essentially work the same way: Android has several default audio effects built into its operating system that these apps can use without any special permissions. Here's a list of those: https://developer.android.com/reference/android/media/audiofx/AudioEffect.

Being restricted to these default built-in audio effects is problematic if you want to implement any advanced custom effects such as Viper or JDSP, because Android does not allow apps to access & modify the audio stream directly.

To work around this problem, RootlessJamesDSP uses a bunch of tricks to gain full access to the audio stream of other apps. This is done via Android's internal audio capture. This allows RootlessJamesDSP to apply its custom audio effects directly without relying on Android's built-in effects.

Unfortunately, these tricks are not 100% reliable and introduce some limitations. Apps such as Spotify block internal audio capture (they don't want people to record their songs), and because of that, RootlessJamesDSP cannot directly access the audio stream of that app. This is the reason why a special patch is required to disable this DRM restriction inside Spotify's app. Patches for other apps with these DRM restrictions do not exist, but are possible to do.

Wavelet can only use Android's default bundled audio effects and works differently from RootlessJamesDSP because of that.

RootlessJamesDSP has to inject a custom audio effect that is not approved by Android, and those cannot use legacy mode without root access.

@timschneeb timschneeb closed this as not planned Won't fix, can't repro, duplicate, stale Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants