Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Intervention] Unable to preventDefault inside passive event listener due to target being treated as passive. #8

Closed
dewita opened this issue Mar 26, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@dewita
Copy link

dewita commented Mar 26, 2019

Hi !

I'm using the clipper-fixed component to do my stuff but i get the error as written in the title.

This is related to that thread.

can you help me ? :)

@dewita
Copy link
Author

dewita commented Mar 26, 2019

As you can see, I have the same problem with your examples.

error_case

@timtnleeProject timtnleeProject added the enhancement New feature or request label Mar 27, 2019
@timtnleeProject
Copy link
Owner

Hi @dewita ,
thanks for this important information.
We need to use passive events for a better scrolling experience.

I use it on touch events but missing the wheel event.

Here's where I define window wheel event (src\components\extends\clippo.js)

Original

const rxWheelListeners = {
  beforeCreate() {
    this.wheel$ = fromEvent(window, 'wheel')
  }
}

Will be fixed at next version

const rxWheelListeners = {
  beforeCreate() {
    this.wheel$ = fromEvent(window, 'wheel', { passive: false })
  }
}

@dewita
Copy link
Author

dewita commented Mar 27, 2019

Seems clear !

Thanks for your maintenance @timtnleeProject

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants