Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't change default number of download #39

Closed
jbatmalle opened this issue May 30, 2021 · 3 comments
Closed

Can't change default number of download #39

jbatmalle opened this issue May 30, 2021 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jbatmalle
Copy link

Hi,
In my docker-compose I use the following environment variables:
- MAX_DOWNLOADS=100
- DOWNLOAD_COUNTS=10,15,50,100
But it can't change default number of download (set to 1 strangly)
I see 10 downloads on web page but when I send my file 1 is selected
Note: When I change current download item on web page it's work

I try this
- MAX_DOWNLOADS=100
- DOWNLOAD_COUNTS=10,1,15,50,100
or
- MAX_DOWNLOADS=100
- DOWNLOAD_COUNTS=10,2,1,15,50,100
But not work. 1 is alway selected

I don't see anything in config.js for help me

@timvisee
Copy link
Owner

There is currently no property to set the default number of downloads.

I'll try to implement this tomorrow. If there's anybody else that would like to give this a try in the mean time, go ahead.

@timvisee timvisee added enhancement New feature or request good first issue Good for newcomers labels May 30, 2021
@timvisee
Copy link
Owner

timvisee commented Jun 4, 2021

I've just implemented this. You can use the DEFAULT_DOWNLOADS variable to set a default.

This is part of v3.4.12, which should be available as soon as this release pipeline succeeds: https://gitlab.com/timvisee/send/-/pipelines/314975915

I was busier than expected, so it took me a little longer than a day. Sorry for that.

@jbatmalle
Copy link
Author

Hi @timvisee,
No worries about the delay :)
I checked it, it's ok!
Thank you a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants