Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Configure Slack range in terms of distance, rather than steps #8

Open
ryanball opened this issue Jul 27, 2016 · 5 comments

Comments

@ryanball
Copy link
Contributor

This is similar to what is on the roadmap, but feel that a value like this would greatly help people who want to make a slack notification for their office!

@timwah
Copy link
Owner

timwah commented Jul 27, 2016

Do you mean the NUM_STEPS variable defined in terms of distance? It's a little tricky to change because the implementation is mostly from the PokemonGo-Map project, but is doable if we dissect the code more.

@ryanball
Copy link
Contributor Author

So my understanding is NUM_STEPS determines search distance. Say num steps==5, but I only want to be notified if something is within .25 miles of my location. Yes the search has some waste in it now, but steps aren't very granular

@timwah
Copy link
Owner

timwah commented Jul 27, 2016

I see, yeah that's a good point. Lots of wasted time searching space that you're not even interested. The notification can be a lot more instantaneous if we just searched explicitly. I can add to the roadmap, great suggestion.

@me0wday
Copy link

me0wday commented Jul 27, 2016

is there any rough estimate as to what the step and step size means? ie what kind of radius from the point selected the values would be?

@irongollem
Copy link

I thought every step is 100m. So 300m is 3 steps, 250m is 3 steps, 200m is 2 steps etc. Its the go API. To implement a meters setting a simple convertion and rounding function has to be done, but this would also require checking A: wether steps or units and B: if units, is it in meters of miles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants