-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jquery-mosaic not showing all images #12
Comments
Hey Borek, take a deeper look to the documentation, that’s a the expected behavior, and you can even control it.
… On 1 Dec 2017, at 20:19, Borek Lupoměský ***@***.***> wrote:
Demos looked nice, so I put together very simple CodePen test:
https://codepen.io/cenozoic/pen/WXLBZB?editors=1010
There are 5 (same) images in it. But jquery-mosaic shows sometimes 3, sometimes 4, almost never all 5 (just resize the viewport to see this). That looks pretty unusable for a gallery.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
@borekl sounds responsive! |
@tin-cat Oh, I stand corrected, I didn't realize that 'skip' is the default. BTW, how about implementing another policy 'tail' that would leave the last row not fully filled (with the height at maxRowHeight)? |
Hi @borekl, I agree! That new policy for the maxRowHeight parameter would be nice to have! Will have a try at i! Thanks! |
Hi! I added a new maxRowHeight policy called 'tail' just as you suggested, I think it works, give it a try and let me know! You can see it working here: http://jquery-mosaic.tin.cat/example_maxrowheightpolicy.php?randomSeed=9 |
@tin-cat Great! Thanks for implementing this, I am moving to your tiling code (over from perfect-layout). |
Great @borekl! First give it a try to see if the new 'tail' policy works well, I did some tests and it seems to work well, but it's a fresh implementation and should be thoroughly tested before releasing it officially! Also, let us know the URL where you're implementing it so we can see it in action! :D |
Demos looked nice, so I put together very simple CodePen test:
https://codepen.io/cenozoic/full/WXLBZB/
There are 5 (same) images in it. But jquery-mosaic shows sometimes 3, sometimes 4, almost never all 5 (just resize the viewport to see this). That looks pretty unusable for a gallery.
The text was updated successfully, but these errors were encountered: