Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jquery-mosaic not showing all images #12

Closed
borekl opened this issue Dec 1, 2017 · 7 comments
Closed

jquery-mosaic not showing all images #12

borekl opened this issue Dec 1, 2017 · 7 comments

Comments

@borekl
Copy link
Contributor

borekl commented Dec 1, 2017

Demos looked nice, so I put together very simple CodePen test:

https://codepen.io/cenozoic/full/WXLBZB/

There are 5 (same) images in it. But jquery-mosaic shows sometimes 3, sometimes 4, almost never all 5 (just resize the viewport to see this). That looks pretty unusable for a gallery.

@tin-cat
Copy link
Owner

tin-cat commented Dec 1, 2017 via email

@sebbean
Copy link

sebbean commented Dec 2, 2017

@borekl sounds responsive!

@borekl borekl closed this as completed Dec 2, 2017
@borekl
Copy link
Contributor Author

borekl commented Dec 2, 2017

@tin-cat Oh, I stand corrected, I didn't realize that 'skip' is the default. BTW, how about implementing another policy 'tail' that would leave the last row not fully filled (with the height at maxRowHeight)?

@tin-cat
Copy link
Owner

tin-cat commented Dec 2, 2017

Hi @borekl, I agree! That new policy for the maxRowHeight parameter would be nice to have! Will have a try at i! Thanks!

@tin-cat
Copy link
Owner

tin-cat commented Dec 2, 2017

Hi! I added a new maxRowHeight policy called 'tail' just as you suggested, I think it works, give it a try and let me know! You can see it working here:

http://jquery-mosaic.tin.cat/example_maxrowheightpolicy.php?randomSeed=9

@borekl
Copy link
Contributor Author

borekl commented Dec 2, 2017

@tin-cat Great! Thanks for implementing this, I am moving to your tiling code (over from perfect-layout).

@tin-cat
Copy link
Owner

tin-cat commented Dec 2, 2017

Great @borekl! First give it a try to see if the new 'tail' policy works well, I did some tests and it seems to work well, but it's a fresh implementation and should be thoroughly tested before releasing it officially! Also, let us know the URL where you're implementing it so we can see it in action! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants