Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay when navigating the Tina Cloud Starter #149

Closed
scottgallant opened this issue Aug 5, 2021 · 11 comments · Fixed by tinacms/tinacms#2015
Closed

Delay when navigating the Tina Cloud Starter #149

scottgallant opened this issue Aug 5, 2021 · 11 comments · Fixed by tinacms/tinacms#2015

Comments

@scottgallant
Copy link
Member

Navigating around the starter feels clunky. If you click a page it takes a few seconds to load.

https://www.loom.com/share/acfa34eb297e4d2ba40ade1edf71b7a2

@mitchmac
Copy link
Contributor

mitchmac commented Aug 5, 2021

@scottgallant is your site running from yarn dev with the localclient in the video?

@scottgallant
Copy link
Member Author

Running on Vercel after completing the starter flow

@mitchmac
Copy link
Contributor

mitchmac commented Aug 5, 2021

@scottgallant I think I see the editing pencil, so edit mode was on?

@scottgallant
Copy link
Member Author

Yes

@spbyrne
Copy link
Contributor

spbyrne commented Aug 5, 2021

That seems quite slow. Also there's a spinner that's designed to show when loading content, and a different spinner when editing is enabled.. neither seem to be showing. I wonder what it's hanging on specifically.

@DirtyF
Copy link
Contributor

DirtyF commented Aug 6, 2021

I don't reproduce this behaviour, when connected I can see a loading state before the page is editable:
https://www.loom.com/share/043329a113524873adc8e9c76f4cd5d8

@mitchmac
Copy link
Contributor

mitchmac commented Aug 6, 2021

Maybe a dark mode issue?

@spbyrne
Copy link
Contributor

spbyrne commented Aug 6, 2021

I don't think so.

@DirtyF
Copy link
Contributor

DirtyF commented Aug 6, 2021

Just did a quick test and I can see the overlay too in dark mode.

@logan-anderson
Copy link
Contributor

@scottgallant @spbyrne @mitchmac

This issue happens in edit mode. Its because the props are being fetched from Github which is slow. We should probably go into a loading state when this happens.

@mitchmac
Copy link
Contributor

mitchmac commented Aug 9, 2021

Loading state should be more helpful with next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants