Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy Tina implementation from tina.io #1178

Closed
8 tasks done
jamespohalloran opened this issue Jan 20, 2022 · 6 comments · Fixed by #1220
Closed
8 tasks done

Remove legacy Tina implementation from tina.io #1178

jamespohalloran opened this issue Jan 20, 2022 · 6 comments · Fixed by #1220
Labels
dx Anything that adds friction to DX

Comments

@jamespohalloran
Copy link
Contributor

jamespohalloran commented Jan 20, 2022

Right now we have a dated pre-TinaCloud version of Tina on tina.io. It uses unsupported features like open-authoring, inline-editing, frontend github-backend, etc.

It will be easier to add the current version of Tina once we remove this dated implementation.

@gitsstewart
Copy link
Contributor

We'll time box this effort to 2 days. If it gets too hairy we can take a step back and re-visit how to do this.

@gitsstewart
Copy link
Contributor

gitsstewart commented Jan 31, 2022

First person to work on this needs to document the approach here so that there is consistency. Also create a punchlist here.

@logan-anderson
Copy link
Contributor

First person to work on this needs to document the approach here so that there is consistency. Also create a punchlist here.

@spbyrne removed tina from the community page in #1210. We can follow this approach for consistency.

@spbyrne
Copy link
Contributor

spbyrne commented Feb 1, 2022

I'm going to take on the homepage. I recall using a blocks renderer that I can dig up or recreate so it shouldn't be too hard.

@spbyrne
Copy link
Contributor

spbyrne commented Feb 1, 2022

I'm mainly stripping out inline components by taking something like <InlineTextarea name="subline" /> and replacing it with {data.subline}, plus removing the Tina form. The specifics will depend on the page, though.

@logan-anderson
Copy link
Contributor

logan-anderson commented Feb 1, 2022

@spbyrne

👍 I am going to tackle the docs page. I also removed the gihhub data fetching in getDocsProps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dx Anything that adds friction to DX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants