Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improperly defined peer dependencies #1110

Closed
Muthaias opened this issue May 7, 2020 · 1 comment · Fixed by #1295
Closed

Improperly defined peer dependencies #1110

Muthaias opened this issue May 7, 2020 · 1 comment · Fixed by #1295
Labels
bug Something isn't working dx Related to Developer Experience good first issue Good for newcomers!

Comments

@Muthaias
Copy link

Muthaias commented May 7, 2020

Description

The following peer dependencies can't be met:

npm ERR! peer dep missing: prop-types@>15, required by @tinacms/form-builder@0.3.2
npm ERR! peer dep missing: prop-types@>15, required by @tinacms/react-sidebar@0.1.2
npm ERR! peer dep missing: prop-types@>15, required by @tinacms/react-toolbar@0.1.0
npm ERR! peer dep missing: prop-types@>15, required by @tinacms/form-builder@0.3.2

Steps to reproduce

yarn add "tinacms@0.19.0"
yarn add "prop-types@>15"
Note that prop-types currently only goes to version 15.x which is not covered by this. I would expect @>=15 here instead.

Expected result

Being able to install the required peer dependencies

Actual result

No available peer dependencies that meets requirements.

Environment

node: v10.16.0
npm: 6.9.0

Tinacms Package Versions

├─┬ tinacms@0.19.0
│ ├── @tinacms/alerts@0.1.2
│ ├── @tinacms/core@0.7.4
│ ├─┬ @tinacms/fields@0.10.0
│ ├─┬ @tinacms/form-builder@0.3.2
│ ├─┬ @tinacms/forms@0.4.1
│ ├── @tinacms/icons@0.9.0
│ ├── @tinacms/media@0.1.0
│ ├── @tinacms/react-alerts@0.1.2
│ ├─┬ @tinacms/react-core@0.2.11
│ ├─┬ @tinacms/react-forms@0.1.2
│ ├── @tinacms/react-modals@0.1.2
│ ├── @tinacms/react-screens@0.1.1
│ ├─┬ @tinacms/react-sidebar@0.1.2
│ ├─┬ @tinacms/react-toolbar@0.1.0
│ ├── @tinacms/styles@0.4.2
│ └─┬ react-tinacms-editor@0.5.0
│   ├─┬ @tinacms/react-forms@0.1.2-alpha.0
@Muthaias Muthaias added the bug Something isn't working label May 7, 2020
@ncphillips ncphillips added the good first issue Good for newcomers! label May 7, 2020
@kendallstrautman kendallstrautman added the dx Related to Developer Experience label May 14, 2020
@kendallstrautman
Copy link
Contributor

Improved via #1129?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dx Related to Developer Experience good first issue Good for newcomers!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants