Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMD/CTRL+S to save forms #3493

Closed
wants to merge 9,628 commits into from
Closed

CMD/CTRL+S to save forms #3493

wants to merge 9,628 commits into from

Conversation

Maxobat
Copy link
Contributor

@Maxobat Maxobat commented Jan 1, 2023

To make the editing experience more seamless, keybindings for saving the form were added. Now, Command+s or Control+s will trigger a submit on the form, just clicking the save button. Each action follows the states of the save button; if it's disabled/busy/etc., the key bindings will no-op.

jeffsee55 and others added 30 commits November 1, 2022 12:22
…tina-with-node-1418

Display an error when node version < 14.18
Fix console error message about multiple field nodes
Include node_modules as part of the build in @tinacms/app
added the ability to hide the delete and create buttons
Fix issue with deeply nested rich-text parsing
@Maxobat Maxobat requested a review from a team as a code owner January 1, 2023 18:39
@changeset-bot
Copy link

changeset-bot bot commented Jan 1, 2023

🦋 Changeset detected

Latest commit: fdbc09e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@tinacms/toolkit Minor
tinacms Patch
starter-basic-iframe Patch
starter-basic Patch
starter-empty Patch
e2e-next Patch
kitchen-sink-starter Patch
@tinacms/starter-iframe Patch
@tinacms/starter Patch
kitchen-sink Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Jan 1, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 1, 2023

Warnings
⚠️

packages/@tinacms/schema-tools was modified but its README.md was not updated. Please check if any changes should be reflected in the documentation.

⚠️

packages/@tinacms/metrics was modified but its README.md was not updated. Please check if any changes should be reflected in the documentation.

⚠️

packages/@tinacms/mdx was modified but its README.md was not updated. Please check if any changes should be reflected in the documentation.

⚠️

packages/@tinacms/auth was modified but its README.md was not updated. Please check if any changes should be reflected in the documentation.

⚠️

packages/@tinacms/app was modified but its README.md was not updated. Please check if any changes should be reflected in the documentation.

⚠️ Could not find package: packages/gatsby-plugin-cms: Not Found
⚠️ Could not find package: packages/gatsby-demo: Not Found
⚠️ Could not find package: packages/cra-demo: Not Found
⚠️ Could not find package: packages/cms: Not Found
⚠️ Could not find package: packages/cms-react-sidebar: Not Found
⚠️ Could not find package: packages/cms-final-form-builder: Not Found
Messages
📖

Modified CI Scripts

  • .github/workflows/danger.yml
  • .github/workflows/e2e-dev.yml
  • .github/workflows/e2e.yml
  • .github/workflows/main.yml
  • .github/workflows/publish-pr.yml
  • .github/workflows/publish.yml
  • dangerfile.ts

Modified Packages

The following packages were modified by this pull request:

  • @tinacms/app
  • @tinacms/auth
  • @tinacms/cli
  • @tinacms/datalayer
  • @tinacms/graphql
  • @tinacms/mdx
  • @tinacms/metrics
  • @tinacms/schema-tools
  • @tinacms/scripts
  • @tinacms/sharedctx
  • @tinacms/toolkit
  • @tinacms/webpack-helpers
  • create-tina-app
  • next-tinacms-cloudinary
  • next-tinacms-dos
  • next-tinacms-s3
  • tinacms

Generated by 🚫 dangerJS against fdbc09e

Copy link
Contributor

@jamespohalloran jamespohalloran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Will be a handy addition. Just left a few comments.

@Maxobat
Copy link
Contributor Author

Maxobat commented Jan 7, 2023

@jamespohalloran This is my first PR on Tina; for some reason the license/cla check is failing, even though I signed it. Thoughts as to how I resolve that? Thanks!

@jamespohalloran
Copy link
Contributor

Pr approved! Thanks again for this. For the license/cla check, it looks like the commits may have a different email than what you've signed the agreement with.
https://stackoverflow.com/questions/750172/how-do-i-change-the-author-and-committer-name-email-for-multiple-commits

@Maxobat
Copy link
Contributor Author

Maxobat commented Jan 11, 2023

@jamespohalloran Sorry, tried to fix the email thing, but it did some unintentional changes. I'll fix and get back to you. But hey, at least the license thing is fixed lol.

@Maxobat Maxobat closed this by deleting the head repository Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet