New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMD/CTRL+S to save forms #3493
CMD/CTRL+S to save forms #3493
Conversation
don't compile client
…tina-with-node-1418 Display an error when node version < 14.18
… fix some missing new types
Simplify formify resolve
Unwrap image block
Update config and schema types
Fix console error message about multiple field nodes
Version Packages
Include node_modules as part of the build in @tinacms/app
added the ability to hide the delete and create buttons
Fix issue with deeply nested rich-text parsing
Fix/admin work in docker container
Feat/billing warning
Feat/forestry migration tool
Version Packages
🦋 Changeset detectedLatest commit: fdbc09e The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Modified PackagesThe following packages were modified by this pull request:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! Will be a handy addition. Just left a few comments.
packages/@tinacms/toolkit/src/packages/form-builder/FormBuilder.tsx
Outdated
Show resolved
Hide resolved
packages/@tinacms/toolkit/src/packages/form-builder/FormBuilder.tsx
Outdated
Show resolved
Hide resolved
@jamespohalloran This is my first PR on Tina; for some reason the license/cla check is failing, even though I signed it. Thoughts as to how I resolve that? Thanks! |
Pr approved! Thanks again for this. For the license/cla check, it looks like the commits may have a different email than what you've signed the agreement with. |
@jamespohalloran Sorry, tried to fix the email thing, but it did some unintentional changes. I'll fix and get back to you. But hey, at least the license thing is fixed lol. |
To make the editing experience more seamless, keybindings for saving the form were added. Now, Command+s or Control+s will trigger a submit on the form, just clicking the save button. Each action follows the states of the save button; if it's disabled/busy/etc., the key bindings will no-op.