Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remix Starter has TypeScript errors with URLSearchParams #4378

Closed
3 tasks done
jwithington opened this issue Nov 28, 2023 · 2 comments
Closed
3 tasks done

Remix Starter has TypeScript errors with URLSearchParams #4378

jwithington opened this issue Nov 28, 2023 · 2 comments
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@jwithington
Copy link

jwithington commented Nov 28, 2023

I was trying to run the remix starter, following the steps in the docs, but due to TypeScript errrors, the main localhost page wouldn't load.

Error from the page:

ypeError: Value of "this" must be of type URLSearchParams
    at new NodeError (node:internal/errors:405:5)
    at Proxy.set (node:internal/url:572:13)
    at Proxy.<anonymous> (/Users/jwithy/tina-cms-test/my-tina-app/node_modules/@remix-run/web-fetch/src/headers.js:124:44)
    at createRemixHeaders (/Users/jwithy/tina-cms-test/my-tina-app/node_modules/@remix-run/express/dist/server.js:58:17)
    at createRemixRequest (/Users/jwithy/tina-cms-test/my-tina-app/node_modules/@remix-run/express/dist/server.js:73:14)
    at /Users/jwithy/tina-cms-test/my-tina-app/node_modules/@remix-run/express/dist/server.js:37:21
    at /Users/jwithy/tina-cms-test/my-tina-app/node_modules/@remix-run/serve/dist/index.js:48:7
    at Layer.handle [as handle_request] (/Users/jwithy/tina-cms-test/my-tina-app/node_modules/express/lib/router/layer.js:95:5)
    at next (/Users/jwithy/tina-cms-test/my-tina-app/node_modules/express/lib/router/route.js:144:13)
    at next (/Users/jwithy/tina-cms-test/my-tina-app/node_modules/express/lib/router/route.js:140:7)
image

Reproduction

https://github.com/tinacms/tina-hugo-starter

Steps to reproduce

  • run the npx create-tina-app@latest command
  • use npm instead of yarn (I had different problems when I tried to use Yarn, probably due to macOS issues on my new-ish laptop)
  • pick the remix starter
  • cd into the right folder and use npm run dev

Note: I was using Arc browser (which is Chromium-based), though it's not listed below in system info.

System Info

System:
    OS: macOS 13.4.1
    CPU: (8) arm64 Apple M2
    Memory: 869.48 MB / 24.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.6.1 - /opt/homebrew/bin/node
    Yarn: 1.22.19 - ~/tina-cms-test/my-tina-app/node_modules/.bin/yarn
    npm: 9.8.1 - /opt/homebrew/bin/npm
  Browsers:
    Brave Browser: 117.1.58.124
    Edge: 119.0.2151.72
    Safari: 16.5.2
  npmPackages:
    @tinacms/cli: ^1.5.30 => 1.5.30
    tinacms: ^1.5.21 => 1.5.21

Validations

@jwithington jwithington added the bug Something isn't working label Nov 28, 2023
@kldavis4
Copy link
Member

looks like this issue: remix-run/remix#6118

Copy link

stale bot commented May 31, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label May 31, 2024
@stale stale bot closed this as completed Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants