Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need simple config option to support cookieconsent location:true #57

Closed
localegirl opened this issue Jun 7, 2019 · 4 comments
Closed

Comments

@localegirl
Copy link

Bug Report or Feature Request (mark with an x)

- [ ] bug report -> please search issues before submitting
- [x ] feature request

CookieConsent and Library Versions?

- cookieconsent version: 3.1.1
- ngx-cookieconsent version: 2.2.2

OS Version?

MacOS Mojave

Angular, Node and al Versions?

Angular CLI: 6.2.3
Node: 11.14.0
Angular: 6.1.9

Repro steps

N/A

The log given by the failure

N/A

Desired functionality

https://cookieconsent.osano.com/documentation/javascript-api/ indicates that you can specify location:true in the configuration to easily enable the display of the popup only in countries that require it (and hide in others).

ngx-cookieconsent does not appear to support this, since the Typescript compiler requires an NgcLocationOptions object.

Is there an easy way to configure this? If not, would it be possible to add support for it?

Mention any other details that might be useful

@tinesoft
Copy link
Owner

Hi @localegirl,

This is a valid request. Thanks for reporting 👍
I will update the typings tonight to allow this.

Expect a new feature release to come out, hopefully tonight

Cheers!

@localegirl
Copy link
Author

Great! Thanks!

@tinesoft
Copy link
Owner

Released under v2.2.3

Enjoy! :)

@localegirl
Copy link
Author

Awesome! Thanks for the quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants