Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update component image versions to latest #108

Merged
merged 4 commits into from
Oct 4, 2021

Conversation

detiber
Copy link
Contributor

@detiber detiber commented Oct 1, 2021

Description

Updates tink, boots, and hegel images to the latest published images (as of Oct 1, 2021)

Why is this needed

Prepare sandbox for an updated release

How Has This Been Tested?

  • Manual verification of vagrant/libvirt deployment based on current documentation completes successfully
  • Manual verification of terraform deployment
  • Manual verification of compose deployment over existing environment
  • Verify github.com/tinkerbell/cluster-api-provider-tinkerbell using compose deployment above

How are existing users impacted? What migration steps/scripts do we need?

No impact to existing users as far as I was able to tell through my manual testing described above.

Comment on lines +23 to +33
variable "use_ssh_agent" {
type = bool
description = "Use ssh agent to connect to provisioner machine"
default = false
}

variable "ssh_private_key" {
type = string
description = "ssh private key file to use"
default = "~/.ssh/id_rsa"
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously if a user had a password protected ssh key, provisioning would fail.

This allows users to either override the private key file used, or choose to use an ssh agent to handle authentication.

Comment on lines +19 to +22
config.vm.provider :libvirt do |libvirt|
libvirt.qemu_use_session = false
end

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously, if a user tries to stand up the vagrant environment in libvirt it would fail because the default for using user sessions does not allow the creation of a bridge device, which is needed by our networking configuration.

@detiber detiber changed the title [WIP] Update component image versions to latest Update component image versions to latest Oct 1, 2021
@jacobweinstock jacobweinstock merged commit 41a7ae3 into tinkerbell:main Oct 4, 2021
@detiber detiber deleted the updateImages branch October 5, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants