Use a stable image for tink-server, tink-worker and tink-cli #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Moath Qasim <moad.qassem@gmail.com>
moadqassem
changed the title
Sure thing, btw, is there any kinda process for backporting things into previous releases? |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current image that is used in the main branch doesn't work due to the issue which is reported here: #143. There was a PR which addressed this issue already which can be found here tinkerbell/tink#632. This PR uses the latest
tink-server,tink-workerandtink-cliwhich has the fix already in place.Why is this needed
Fixes: #
How Has This Been Tested?
vTINKtosha-16186501How are existing users impacted? What migration steps/scripts do we need?
I haven't updated any other components or image except the tink image.
Checklist:
I have: