Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup not required cleanup sql script #30

Merged
merged 1 commit into from
Dec 10, 2020

Conversation

gianarb
Copy link
Contributor

@gianarb gianarb commented Dec 10, 2020

Since we introduced migration the init file is not required and it is a
leftover.

This PR removes it

Since we introduced migration the init file is not required and it is a
leftover.

Signed-off-by: Gianluca Arbezzano <gianarb92@gmail.com>
@gianarb gianarb force-pushed the fix/cleanup-not-required-sql-init branch from 2baaa91 to 22f6f22 Compare December 10, 2020 13:42
@gianarb gianarb added the ci-check/vagrant-setup This label trigger a GitHub action that tests the Vagrant Setup guide https://tinkerbell.org/setup/ label Dec 10, 2020
@gianarb gianarb added the ready-to-merge Signal to Mergify to merge the PR. label Dec 10, 2020
Copy link

@thebsdbox thebsdbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome turn around!

/lgtm

@gianarb gianarb removed the request for review from gauravgahlot December 10, 2020 14:05
@gianarb gianarb merged commit 2499b89 into master Dec 10, 2020
@gianarb gianarb deleted the fix/cleanup-not-required-sql-init branch December 10, 2020 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-check/vagrant-setup This label trigger a GitHub action that tests the Vagrant Setup guide https://tinkerbell.org/setup/ ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants