Fix vagrant config for libvirt #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have zero experience with that. @gauravgahlot somebody is can verify that from your end?! Or @thebsdbox do you use libvirt? :) |
detiber
changed the title
|
|
gianarb
added
ci-check/vagrant-setup
detiber
changed the title
detiber
commented
Jan 25, 2021
| libvirt__dhcp_enabled: false, | ||
| libvirt__forward_mode: 'none', | ||
| libvirt__adapter: 1, |
There was a problem hiding this comment.
This was needed to ensure that the private network isn't accidentally picked up as eth0 instead of eth1.
| @@ -56,6 +60,8 @@ Vagrant.configure('2') do |config| | |||
| lv.cpus = 1 | |||
| lv.boot 'network' | |||
| lv.mgmt_attach = false | |||
| lv.storage :file, :size => '40G' | |||
There was a problem hiding this comment.
Without this, you cannot actually run a workflow that does something like install an OS to disk.
|
CI check seems to be failing on an issue unrelated to this PR. |
|
Yep fixed via #44 , do you mind rebasing, please? |
gianarb
approved these changes
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the vagrant configuration when using libvirt
Why is this needed
Without this issue the vagrant provisioner fails when using libvirt with the following error:
How Has This Been Tested?
Reran vagrant up after making the changes and the provisioner machine successfully was created
How are existing users impacted? What migration steps/scripts do we need?
Should not affect existing users unless they were trying to use vagrant/libvirt and were unsuccessful before.
No migration should be needed.