Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes conflicting composefile network instruction per #53 for boots… #56

Merged
merged 1 commit into from
Feb 18, 2021

Conversation

jmarhee
Copy link
Contributor

@jmarhee jmarhee commented Feb 17, 2021

… container definition

Description

Resolves #53

Why is this needed

This conflict causes container creation to fail.

Fixes: #

How Has This Been Tested?

I ran the setup and was able to run a workflow and deployment without issue.

How are existing users impacted? What migration steps/scripts do we need?

No impact.

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

…for boots container definition

Signed-off-by: Joseph D. Marhee <jmarhee@interiorae.com>
@gianarb
Copy link
Contributor

gianarb commented Feb 18, 2021

Thanks a lot!!

@gianarb gianarb removed the request for review from gauravgahlot February 18, 2021 07:49
@gianarb gianarb added the ready-to-merge Signal to Mergify to merge the PR. label Feb 18, 2021
@mergify mergify bot merged commit b46a724 into tinkerbell:master Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker Compose: "host" network_mode is incompatible with port_bindings
2 participants