pin boots to TINKERBELL_HOST_IP instead of 0.0.0.0 #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is currently working, but I am planning on trying to see if only a partial reversion is sufficient rather than reverting all of the settings back (command line, env variables, and port configuration). |
detiber
changed the title
|
Looks like the port configuration is not needed, so I removed it. The other bits appear to still be needed. |
thebsdbox
approved these changes
Mar 19, 2021
gianarb
added
the
ci-check/vagrant-setup
|
Thanks a lot |
gianarb
approved these changes
Mar 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reverts the docker-compose file back to pinning boots to TINKERBELL_HOST_IP rather than binding to 0.0.0.0
Why is this needed
Without this it appears that hosts that may have multiple IPs (such as a bare metal host that tinkerbell has been deployed on) fail to properly tftp files to hosts if the traffic enters/leaves the host through separate IPs. For example my host has a static IP of 192.168.1.5 before deploying the sandbox on it. Afterwards it also has 192.168.1.1. Without this change tftp requests from the host during pxe booting timeout and fail. With this change the tftp requests succeed.
How Has This Been Tested?
Tested manually on a physical host that is running Tinkerbell from sandbox
How are existing users impacted? What migration steps/scripts do we need?
This should not affect existing users since it reverts back to pre-existing behavior
Checklist:
I have: