Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Terraform to 0.14 in shell.nix #72

Merged
merged 1 commit into from
Mar 24, 2021

Conversation

nshalman
Copy link
Member

Description

This change causes Nix to pull in Terraform v0.14 rather than v0.12 when users run nix-shell

Why is this needed

Without this change I get this error on both Mac and NixOS:

[nix-shell:~/sandbox/deploy/terraform]$ terraform init --upgrade

Warning: Provider source not supported in Terraform v0.12

  on main.tf line 4, in terraform:
   4:     metal = {
   5:       source  = "equinix/metal"
   6:       version = "1.0.0"
   7:     }

A source was declared for provider metal. Terraform v0.12 does not support the
provider source attribute. It will be ignored.

(and 2 more similar warnings elsewhere)


Error: Unsupported Terraform Core version

This configuration does not support Terraform version 0.12.30. To proceed,
either choose another supported Terraform version or update the root module's
version constraint. Version constraints are normally set for good reason, so
updating the constraint may lead to other errors or unexpected behavior.

How Has This Been Tested?

I used this on both a Mac and a NixOS machine using nix-shell

How are existing users impacted? What migration steps/scripts do we need?

Running nix-shell on existing checkouts will now pull down a newer version of Terraform.

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

@gianarb
Copy link
Contributor

gianarb commented Mar 24, 2021

Thanks @nshalman! Do you mind signing off your commit?

Signed-off-by: Nahum Shalman <nshalman@equinix.com>
@nshalman
Copy link
Member Author

nshalman commented Mar 24, 2021

Thanks @nshalman! Do you mind signing off your commit?

@gianarb should be fixed now.

@gianarb
Copy link
Contributor

gianarb commented Mar 24, 2021

Thanks a lot

@gianarb gianarb removed the request for review from gauravgahlot March 24, 2021 15:06
@gianarb gianarb added the ready-to-merge Signal to Mergify to merge the PR. label Mar 24, 2021
@mergify mergify bot merged commit cc5e0be into tinkerbell:master Mar 24, 2021
@nshalman nshalman deleted the bugfix/terraform-0.14 branch March 24, 2021 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants