Use rsync for vagrant-libvirt sync_folder: #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The NFS type for synced_folder requires nfsd to be installed and running on a machine for vagrant up to be successful. nfs was used so that folders were r/w bidirectionally. I don't really think there is a need for this bidirectional functionality. Moving to rsync should make this work more universally. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
tstromberg
approved these changes
Aug 29, 2021
|
Bringing this over here since I closed the issue
I thought the docker-compose files were expecting the nfs mounts to be available in the vagrant box, but I don't see nfs being used for volumes in these compose files. So I dont' know why they're breaking Annd that being said, it looks like with nfsd I'm getting the same secondary errors with the containers as rsync. So I'll go ahead and collect that info and open a new issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The NFS type for synced_folder requires nfsd to be installed and running on a machine for vagrant up to be successful.
nfs was used so that folders were r/w bidirectionally.
I don't really think there is a need for this bidirectional functionality.
Moving to rsync should make this work more universally.
Why is this needed
Issue #97 reported.
Moving away from nfs for vagrant libvirt synced_folders should work more universally.
Fixes: #97
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: