Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tink workflow events should support --format=json #505

Closed
micahhausler opened this issue Jun 11, 2021 · 6 comments
Closed

tink workflow events should support --format=json #505

micahhausler opened this issue Jun 11, 2021 · 6 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@micahhausler
Copy link
Contributor

Expected Behaviour

I'd like to review the event JSON for deeper inspection. All the other read commands support it

Current Behaviour

No --format supported on tink workflow events $WORKFLOW

Possible Solution

Add a --format flag

@tstromberg tstromberg added kind/feature Categorizes issue or PR as related to a new feature. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Aug 10, 2021
@tstromberg
Copy link
Contributor

I think this sounds like a great idea, and we should totally do this.

As you mentioned, since all of the other read commands support this, it shouldn't be too difficult to add to the events code. I'll mark this as a good first issue.

@displague
Copy link
Member

The table writer can be reused here as in https://github.com/tinkerbell/tink/blob/master/cmd/tink-cli/cmd/get/get.go#L95-L146

https://github.com/tinkerbell/tink/blob/master/cmd/tink-cli/cmd/workflow/get.go#L42-L50 would need to build an object to emit rather than println'ing each item.

@tstromberg tstromberg added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Aug 27, 2021
@krishnanarchana
Copy link
Contributor

@tstromberg , I have started working on this issue -- could I've this assigned to me?

@hitesh-infracloud
Copy link

@tstromberg could you please take a look at this PR: #646? I am unable to add anyone as reviewer.

@chrisdoherty4
Copy link
Member

@hitesh-infracloud Thank you for the PR. In relation to this issue, we recently decided to deprecate the Postgres back-end and remove it entirely in the near future. This would see the CLI either reduce significantly in scope or disappear entirely as operators would interact with state via kubectl instead.

If the JSON output isn't strictly needed right now it probably isn't worth adding given it'll be removed in the near future.

Would love to hear your feedback.

@chrisdoherty4
Copy link
Member

Closing the issue after receiving no feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

6 participants