New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tink workflow events
should support --format=json
#505
Comments
I think this sounds like a great idea, and we should totally do this. As you mentioned, since all of the other read commands support this, it shouldn't be too difficult to add to the events code. I'll mark this as a good first issue. |
The table writer can be reused here as in https://github.com/tinkerbell/tink/blob/master/cmd/tink-cli/cmd/get/get.go#L95-L146 https://github.com/tinkerbell/tink/blob/master/cmd/tink-cli/cmd/workflow/get.go#L42-L50 would need to build an object to emit rather than println'ing each item. |
@tstromberg , I have started working on this issue -- could I've this assigned to me? |
@tstromberg could you please take a look at this PR: #646? I am unable to add anyone as reviewer. |
@hitesh-infracloud Thank you for the PR. In relation to this issue, we recently decided to deprecate the Postgres back-end and remove it entirely in the near future. This would see the CLI either reduce significantly in scope or disappear entirely as operators would interact with state via If the JSON output isn't strictly needed right now it probably isn't worth adding given it'll be removed in the near future. Would love to hear your feedback. |
Closing the issue after receiving no feedback. |
Expected Behaviour
I'd like to review the event JSON for deeper inspection. All the other read commands support it
Current Behaviour
No
--format
supported ontink workflow events $WORKFLOW
Possible Solution
Add a
--format
flagThe text was updated successfully, but these errors were encountered: