Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix existing e2e tests for workflow #80

Closed
gauravgahlot opened this issue Apr 24, 2020 · 2 comments
Closed

Fix existing e2e tests for workflow #80

gauravgahlot opened this issue Apr 24, 2020 · 2 comments
Assignees
@parauliya
Labels
priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
Issues List

Comments

@gauravgahlot
Copy link
Contributor

The existing e2e tests under https://github.com/tinkerbell/tink/tree/master/test are commented. It would be great to have them fixed and be executed during the CI.
@gauravgahlot gauravgahlot changed the title Fix existing e2e tests for worklfow Fix existing e2e tests for workflow Apr 24, 2020
@mrmrcoleman mrmrcoleman added this to Requests in Issues List May 20, 2020
@mrmrcoleman mrmrcoleman moved this from Requests to Triaged in Issues List Jun 4, 2020
@parauliya parauliya moved this from Triaged to In Progress in Issues List Jun 16, 2020
@mrmrcoleman mrmrcoleman added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Jun 26, 2020
@mrmrcoleman
Copy link
Contributor

@grahamc Try to log into drone.packet.net with your GH account and if it doesn't work let @mrmrcoleman know so he can ask Ben R.

@nathangoulding nathangoulding moved this from In Progress to Triaged in Issues List Jul 9, 2020
@mrmrcoleman mrmrcoleman moved this from Triaged to In Progress in Issues List Jul 24, 2020
@parauliya parauliya moved this from In Progress to Blocked in Issues List Jul 28, 2020
@gianarb gianarb mentioned this issue Aug 6, 2020
Closed
@thebsdbox thebsdbox moved this from Blocked to In Progress in Issues List Aug 11, 2020
@gianarb
Copy link
Contributor

gianarb commented Sep 16, 2020

I think this is not valid anymore, and e2e will be covered by #224

@gianarb gianarb closed this as completed Sep 16, 2020
Issues List automation moved this from In Progress to Just shipped Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parauliya parauliya

Labels
priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
No open projects
Issues List
  
Just shipped
Milestone
No milestone
Development

No branches or pull requests
4 participants
@gianarb @mrmrcoleman @gauravgahlot @parauliya