Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prettier and/or Hugo not registering line breaks #96

Closed
thomcrowe opened this issue Jul 6, 2020 · 3 comments
Closed

Prettier and/or Hugo not registering line breaks #96

thomcrowe opened this issue Jul 6, 2020 · 3 comments
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation. priority/backlog Higher priority than priority/awaiting-more-evidence. size/S estimate of the amount of work to address the issue
Projects

Comments

@thomcrowe
Copy link
Contributor

There seems to be a line break conflict somewhere between running prettier and deploying to staging/live environment where a line break in markdown isn't registered as a line break in live. It looks like prettier is removing the extra white space and taking away the break. Hugo appears to need that double spaces and a carriage return to display the break.

Below are two screenshots, one showing the code for the new docs landing page and the landing page in staging. The contributor line, for example, is mashed into one paragraph instead of displaying the line break.

image

image

@thomcrowe thomcrowe added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jul 6, 2020
@thomcrowe thomcrowe added this to Requests in Issues List via automation Jul 6, 2020
@thomcrowe
Copy link
Contributor Author

Is there a better way we can ensure the line breaks are preserved after running prettier when hugo builds @ronggur?

@DailyAlice DailyAlice added the size/S estimate of the amount of work to address the issue label Jul 21, 2020
@ronggur
Copy link
Contributor

ronggur commented Aug 3, 2020

@thomcrowe according to this issue, it is not possible prettier/prettier#4131 (comment)

But we can ignore it with this documentation https://prettier.io/docs/en/ignore.html

@tstromberg tstromberg added the kind/documentation Categorizes issue or PR as related to documentation. label Jul 27, 2021
@tstromberg tstromberg added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Aug 27, 2021
@jacobweinstock
Copy link
Member

prettier is not used at the moment and the refactor does not seem to have this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation. priority/backlog Higher priority than priority/awaiting-more-evidence. size/S estimate of the amount of work to address the issue
Projects
No open projects
Issues List
  
Requests
Development

No branches or pull requests

5 participants