A bug? #21

Closed

kli-casia opened this issue Nov 3, 2022 · 1 comment · Fixed by #26

Labels

bug

kli-casia commented Nov 3, 2022

CORL/algorithms/dt.py

Line 192 in aa3b5ae

mask = np.hstack(

self.seq_len - states.shape[0] always equal to 0 because pad_along_axis before this line.

The text was updated successfully, but these errors were encountered:

Contributor

Howuhh commented Nov 3, 2022 •

edited

Loading

@kli-casia Yes, indeed! The mask must be created before the paddings. You can do PR with a fix if you want. Otherwise, I'll fix it.

Howuhh added the bug label

Howuhh linked a pull request

that will close this issue

fix mask bug #22

Closed

Howuhh mentioned this issue

fixed late padding mask creation #26

Merged

Scitator closed this as completed in #26

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.