Skip to content

[BUG] Angular 16 Support #42

Open
ahmadchaer opened this issue Jun 8, 2023 · 1 comment · May be fixed by #43
Open

[BUG] Angular 16 Support #42

ahmadchaer opened this issue Jun 8, 2023 · 1 comment · May be fixed by #43
Assignees

Comments

@ahmadchaer
Copy link

🐞 Bug report

Description

Trying to install this library with Angular versions 15 or 16 does not work as it depends on Angular<=14

Reproduction

  1. Create a new Angular 16 App
  2. Add @micro-sentry/angular@6.1.5 to your package.json
  3. npm install

This will give the following error:
npm ERR! Found: @angular/common@16.0.2 npm ERR! node_modules/@angular/common npm ERR! @angular/common@"16.0.2" from the root project npm ERR! npm ERR! Could not resolve dependency: npm ERR! peer @angular/common@"^14.0.0" from @micro-sentry/angular@6.1.5

Expected behavior

To be able to use use it with Angular 15/16

Versions

  • @micro-sentry/core@2.0.0
  • Angular 16
@bufke
Copy link

bufke commented Jun 15, 2023

I'm still willing to work on this but I'd like some direction on loosening peer dependencies. I would suggest we run the ng update migration scripts, make sure it still builds, and set peer dependencies to >=15.

@bufke bufke linked a pull request Jun 30, 2023 that will close this issue
9 tasks
@IKatsuba IKatsuba removed their assignment Jul 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants