Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential merge with base24 #45

Closed
joshgoebel opened this issue Jul 5, 2022 · 5 comments
Closed

Potential merge with base24 #45

joshgoebel opened this issue Jul 5, 2022 · 5 comments
Labels
enhancement New feature or request help wanted Extra attention is needed proposal An idea which may or may not be acted on

Comments

@joshgoebel
Copy link
Contributor

I'd also be happy to work towards a potential merge and am happy to collaborate as I do not see the need to duplicate efforts. The reason I created base24 was to solve the following issues

  • baseXX did not have an organisation with multiple contributors (now it does, and base24 wasn't exactly successful in attracting contribution)
  • base16 does not deal with bright ansi colours

For me, once the following issue is resolved then there is no need for base24

Originally posted by @FredHappyface in #7 (comment)

@joshgoebel joshgoebel added enhancement New feature or request help wanted Extra attention is needed discussion labels Jul 5, 2022
@joshgoebel
Copy link
Contributor Author

I'm splitting this issue out since the base9 maintainer opened (and closed) the prior thread... (which is fine, as it was largely about base9). So now the conversation about Base16/Base24 can move forward here.

@joshgoebel
Copy link
Contributor Author

base16 does not deal with bright ansi colours

Do you know if all the base24 schemes are really base16 themes with +8 colors - or have people taken the liberty to CHANGE the original base16 colors when porting things over? I imagine this might be done - since surely the medium shades offered by all base16 themes before might not always transfer magically to the best light/dark tones.

Personally (if they were all/largely the same) I think it might be nice if the newer base24 schemes replaced the base16 schemes - but builders knew how to build both (from the 24 color sources), ie you could build the base16 version of a base24 schemes easily if you asked the builder to do so.

This would allow all the schemes to stay one unified list rather than splitting into base24 versions, base16 versions, etc... Otherwise we have everything duplicated:

  • schemes
    • base16
      • 3024
    • base24
      • 3024

@joshgoebel
Copy link
Contributor Author

One other idea is to let the builder resolve the differences. IE if a base24 scheme has two different greens (light and dark), those might be mixed/merged if a base16 scheme were built from the base24 scheme... though I'm not sure if that would be better/worse than simply picking the brighter variant, etc...

I think if we want to allow builders to seamlessly work with multiple "types" of "compatible" palettes (which base16 and 24 laregly are) then we'll need a way to abstract tiny pieces of logic into the builders to deal with some of these more subtle details.

@joshgoebel
Copy link
Contributor Author

Conveniently the node builder just works with the baseXX keys it finds (and passes them on), so it supports base24 out of the box with no changes.

@belak belak added proposal An idea which may or may not be acted on and removed discussion labels Jul 8, 2022
@joshgoebel
Copy link
Contributor Author

Closing this as superceded by #49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed proposal An idea which may or may not be acted on
Projects
None yet
Development

No branches or pull requests

2 participants