Skip to content
This repository has been archived by the owner on Apr 5, 2023. It is now read-only.

Update Overhaul: host get-tinypilot.sh script ourselves? #216

Open
jotaen4tinypilot opened this issue Aug 17, 2022 · 1 comment
Open

Update Overhaul: host get-tinypilot.sh script ourselves? #216

jotaen4tinypilot opened this issue Aug 17, 2022 · 1 comment
Labels
medium question Further information is requested

Comments

@jotaen4tinypilot
Copy link
Contributor

When performing a system update, the privileged update script is hard-wired to Github (https://raw.githubusercontent.com).

I’m wondering whether it would make sense to change this URL to a host that we control. The URL is distributed to devices and it might stay there for years (if people are lazy with system updates), which makes it very hard if not impossible to ever change anything about the URL.

Potential scenarios:

  • We want to rename get-tinypilot.sh, or move it into a subfolder. In this case, we would have to keep the original script around, to guarantee backwards compatibility. This is the same problem that we already have with the quick-install script.
  • We move the repo to Gitlab
  • Github is down

The most simple solution I can think of is to create a redirect route in gatekeeper that’s like https://gk.tinypilotkvm.com/get-tinypilot.sh, which issues a 307 redirect to https://raw.githubusercontent.com/tiny-pilot/tinypilot/master/get-tinypilot.sh. That way we wouldn’t have to mirror the script itself.

It would even be possible to version that URL, like https://gk.tinypilotkvm.com/get-tinypilot.sh?version=2.0. Not sure what this could be useful for, but it demonstrates that we might be more flexible.

@mtlynch
Copy link
Contributor

mtlynch commented Aug 17, 2022

I think this is a good thing to do, but I think it can wait until after the update overhaul is done. I want to get it wrapped up ASAP since it's been a long time between releases, and this isn't the kind of thing that necessarily has to happen in sync with the rest of the changes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
medium question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants