Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate button.css into style.css #1769

Open
jotaen4tinypilot opened this issue Apr 1, 2024 · 0 comments
Open

Consolidate button.css into style.css #1769

jotaen4tinypilot opened this issue Apr 1, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@jotaen4tinypilot
Copy link
Contributor

jotaen4tinypilot commented Apr 1, 2024

style.css is already importing button.css, so we automatically have both when we import style.css in web components.

However, in almost all of our web components, we still import both (e.g., see the <update-dialog> as an example.

I’d argue that the button style is as fundamental as any other style definition in style.css, so we could consider refactoring this. E.g.:

  • We copy over the contents from button.css to style.css, and remove all @import "css/button.css directives.
  • We eliminate all redundant @import "css/button.css, but keep the button.css file as separate file for tidiness.
  • We drop the button.css import from style.css, but then we’d be forced to import it in all places where we use it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant