Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasm: allow GOOS=wasip1 to substitute for target=wasi #3685

Closed
codefromthecrypt opened this issue Apr 27, 2023 · 6 comments
Closed

wasm: allow GOOS=wasip1 to substitute for target=wasi #3685

codefromthecrypt opened this issue Apr 27, 2023 · 6 comments
Labels
enhancement New feature or request wasm WebAssembly
Milestone

Comments

@codefromthecrypt
Copy link
Contributor

To allow drop-in replacement with go 1.21, it would seem nice to support GOOS=wasip1 as an alternative to -target=wasi.

Per activity on golang/go#58141, GOOS=wasip1 will ship in Go 1.21 even if a subset of functionality vs the TinyGo equivalent target.

@dgryski
Copy link
Member

dgryski commented Apr 27, 2023

I agree we should do this. We also need to figure out how this will affect build tags. Do we migrate all of tinygo to the new tag to match upstream and add it to the list of tags exported to users, etc.

@aykevl
Copy link
Member

aykevl commented Apr 27, 2023

Same, we should add support for GOOS=wasip1. And perhaps also -target=wasip1 for consistency.

@deadprogram
Copy link
Member

deadprogram commented Aug 10, 2023

Is anyone working on this one yet?

@aykevl
Copy link
Member

aykevl commented Aug 10, 2023

I've made a draft PR for this feature: #3861

@deadprogram deadprogram added the next-release Will be part of next release label Aug 19, 2023
@deadprogram
Copy link
Member

Now that #3861 has merged, I am marking this PR to close on next release. Thanks everyone!

@deadprogram deadprogram removed the next-release Will be part of next release label Aug 26, 2023
@deadprogram
Copy link
Member

Closing since this is part of release 0.29.0 thank you very much everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wasm WebAssembly
Projects
None yet
Development

No branches or pull requests

4 participants