Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"-tags" option should support a comma separated list. #3966

Open
nobonobo opened this issue Oct 20, 2023 · 3 comments
Open

"-tags" option should support a comma separated list. #3966

nobonobo opened this issue Oct 20, 2023 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@nobonobo
Copy link
Contributor

In the Go standard, parameter format for the "-tags" option are comma-separated.

-tags tag,list
a comma-separated list of additional build tags to consider satisfied
during the build. For more information about build tags, see
'go help buildconstraint'. (Earlier versions of Go used a
space-separated list, and that form is deprecated but still recognized.)

@deadprogram deadprogram added the enhancement New feature or request label Nov 4, 2023
@dgryski dgryski added the good first issue Good for newcomers label Nov 4, 2023
@Exar04
Copy link

Exar04 commented Nov 24, 2023

if i am not wrong making following changes in loader/list.go line number 22 will solve the issue, right?

args = append(args, "-tags", strings.Join(config.BuildTags(), " "))

changing it to

args = append(args, "-tags", strings.Join(config.BuildTags(), ","))

@aykevl
Copy link
Member

aykevl commented Nov 25, 2023

@Exar04 no that's just for how to call go list (although it might be a good idea to make that change too). We need to change how build tags are parsed by TinyGo.

@omnide
Copy link

omnide commented Mar 5, 2024

I updated linked PR #4088 with the required golang/tools dependency updates needed to resolve this. My upstream fix to golang/tools was merged before the v0.18.0 tools release cut in mid February.

buildutil fix upstream is: golang/tools@5f90691

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

6 participants