Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add version check to Python impl reader #6

Open
daniel-j-h opened this issue Jan 13, 2023 · 0 comments
Open

Add version check to Python impl reader #6

daniel-j-h opened this issue Jan 13, 2023 · 0 comments

Comments

@daniel-j-h
Copy link
Member

At the moment we do not check the file header version in the Python impl.

We need to check that and bail out in case our reader is not compatible (or no longer compatible) with a file header version.

Ideally we would

  • keep the file header fixed; it's already a fixed size in the spec
  • always read the file header first and check its version
  • based on the version dispatch to specific readers like v1.reader and v2.reader and so on
  • if we can not handle a specific version, bail out
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@daniel-j-h