404 when passing more than 1 middleware to app.method

[theoparis]

Sooooo,
I am having a new issue: the first response gives an actual error/result (which is expected), but on the second request it responds with my 404 noMatchHandler.. It doesn't matteer what the url is on the second request, it just sends the 404 and then complains the headers are already sent.

[talentlessguy]

@creepinson once again I will need a reproducible demo :)

[theoparis]

Oof, I installed the latest version of @tinyhttp/app and got this on almost every page except for /profile....

/ should at least be found here but its not anymore
heres the code: https://hastebin.com/jaxefuqapo.coffeescript

[talentlessguy]

@creepinson interesting, there is some external module made by you. Could you please make a route-only demo that I can try?

Also, body-parser doesn't work. See #25

[talentlessguy]

@creepinson is it still relevant?

[talentlessguy]

I'm not sure if it is still relevant, so closing

feel free to re-open if it persists

[theoparis]

Ok, well I'm still getting a 404 error and it seems to be with using multiple middlewares like so:

My "test" middleware:

async function test(req: Request, res: Response, next?: NextFunction) {
	console.log(`req body: ${JSON.stringify(req.body)}`);
	next!();
}

Then I use it like so:

app.post('/register', test, register);

where the test middleware is supposed to be executed and then after it is called my register middleware in the rest of my code gets called. While it does execute the test middleware and prints out the request body, it then gives the following from the logger middleware:
POST 404 Not Found /register
even though it just worked with the first test middleware.

I will try and make a reproducable demo as well.

[theoparis]

Ok, I've managed to create a simple demo: https://github.com/creepinson/tinyhttp-example/blob/master/src/index.ts

Incorrrect output from the demo:

Listening on :8080
Req url: "/test"
GET 404 Not Found /test

which gives my 404 response back to the curl command.

What should be logged:

Listening on :8080
Req url: "/test"
GET 200 OK /test

and the response should be a json object that was specified in the code.

[theoparis]

I don't think I can reopen this issue manually, I think you have to do it for me because you are the one that closed the issue.

[talentlessguy]

@creepinson, OK reoping

I won't be able to help ya for ~2 weeks so pls be patient :)

[talentlessguy]

Ok, I'm back here

the issue comes from when there are more than 1 wares passed to app.method

will look into this very soon

[talentlessguy]

@creepinson should be fixed now, in this code:

https://github.com/talentlessguy/tinyhttp/blob/53043780f23a716b2664a71c6b367b2dd0e941ec/packages/app/src/router.ts#L91-L98

please check

[theoparis]

seems to be working with my small example :D
I will also try my larger example but I think it might be fixed.