-
-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup Husky pre-commit hook #23
Comments
@talentlessguy Is this issue still open? If it is can I work on it ? |
@rocktimsaikia yes it is, made this one for myself, but it's ok if you do it. I want to setup a pre-commit hook that would run a linter and tests before commiting So we should make a Also make a script to run linter and tests, e.g. Then, install husky, and run this script on pre commit |
@talentlessguy Right. I also had the same idea. Currently, it does not have a separate script for linting so I was gonna create the script and add it to the |
@talentlessguy For some reason, most of the tests are failing even tho I haven't even changed any of the code yet. Just running the test script alone logs a ton of failing tests. Also, I did follow the installation guide provided here so not sure what's causing the tests to fail. Can you tell what might be causing these errors ? |
@rocktimsaikia the reason why tests fail is that I need to update the contributing guide... try running |
@talentlessguy I already tried all of the command solutions. But still the same. Do I need to specifically set some env file configs to run it locally? I think some of the packages are not building upon running the build command. Probably that's why It can't find |
@rocktimsaikia try reloading TS Server (Ctrl + Shift + P -> Reload TS Server) in VS Code |
Closed with #53 🚀 |
No description provided.
The text was updated successfully, but these errors were encountered: