Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not compatible with Node.js v12 because optional chaining in published code #311

Closed
PabloSzx opened this issue Sep 3, 2021 · 3 comments
Closed

Not compatible with Node.js v12 because optional chaining in published code #311

PabloSzx opened this issue Sep 3, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@PabloSzx
Copy link

PabloSzx commented Sep 3, 2021 •
edited

Describe the bug

Code in published library v2.0.0 is not compatible with Node v12 because it's not converting the optional chaining for it to be compatible with Node v12

Screenshot from 2021-09-03 17-50-48

Expected behavior

tinyhttp to actually support Node.js v12 as the announcements mentioned it

Versions

  • node: 12.22.6
  • @tinyhttp/app: 2.0.0
@PabloSzx PabloSzx added the bug Something isn't working label Sep 3, 2021
@PabloSzx PabloSzx mentioned this issue Sep 3, 2021
Closed
@PabloSzx
Copy link
Author

PabloSzx commented Sep 3, 2021

12.22.6 the latest v12, you can see in the screenshot the optional chaining

@talentlessguy
Copy link
Member

weird, TS should transpile this

not sure why it's included in the dist

I probably messed up somewhere in configs

will take a look tomorrow

@PabloSzx
Copy link
Author

PabloSzx commented Sep 7, 2021

@talentlessguy pretty sure this is not normal
image

image

@aldy505 aldy505 mentioned this issue Sep 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PabloSzx @talentlessguy