Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sequential benchmarks should be the default #21

Closed
FINDarkside opened this issue Oct 1, 2022 · 1 comment · Fixed by #22
Closed

Sequential benchmarks should be the default #21

FINDarkside opened this issue Oct 1, 2022 · 1 comment · Fixed by #22

Comments

@FINDarkside
Copy link

FINDarkside commented Oct 1, 2022

This library introduced sequential benches in #18, but there really shouldn't be any other kind of benches. Running multiple benchmarks at the same time means that they are are fighting for the same cpu time, especially since the benches aren't even launched in their own threads.

Running non-sequential benchmarks is pointless because the results are always going to be wrong unless the benchark is completely synchronous in which case they will run sequentially despite the api used or you are testing some external server and each bench tests different server. I think the examples in readme should use the sequential api and possibly the the non-sequential api should just be removed.

@Aslemammad
Copy link
Member

I see, We'll work on this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants