Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the sort function #25

Closed
Aslemammad opened this issue Oct 10, 2022 · 0 comments · Fixed by #29
Closed

fix the sort function #25

Aslemammad opened this issue Oct 10, 2022 · 0 comments · Fixed by #29

Comments

@Aslemammad
Copy link
Member

Aslemammad commented Oct 10, 2022 •
edited

the sort function in https://github.com/tinylibs/tinybench/blob/main/src/task.ts#L76 is not correct, because it only works for strings and as you may know samples are numbers! So fix it to sort numbers.
it should be something like sort((a,b) => a - b) I guess.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: rewrite sort function Morteza-Mazrae/tinybench
1 participant
@Aslemammad