New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
With isolation enabled tinypool keeps worker count at a minimum #23
Comments
So we've got two solutions now: Which one do you suggest? For now, two is more appropriate, which can be a bug! and then 1 |
I think I will add a minThreads/maxThreads override in Vitest for now. |
|
@Demivan Please let's keep Vitest aligned with tinypool! So let's not override, so we can benefit from improvements properly 😄 |
If isolation is enabled
_ensureMinimumWorkers
is called when worker is done. But it only creates a worker if worker count is less then minimum.Because minimum worker count is half of physical core count right now, this means that Tinypool is using only a quarter of actual PC cores. This is really inefficient. On my 16 core CPU Tinypool is using only 4 cores.
The text was updated successfully, but these errors were encountered: