Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing tinypool causes typescript errors. #82

Closed
mshima opened this issue Feb 8, 2024 · 3 comments · Fixed by #91
Closed

Installing tinypool causes typescript errors. #82

mshima opened this issue Feb 8, 2024 · 3 comments · Fixed by #91
Labels
good first issue Good for newcomers

Comments

@mshima
Copy link

mshima commented Feb 8, 2024

Tinypool is conflicting so some dependency:

Error: node_modules/tinypool/dist/index.d.ts(21,15): error TS2417: Class static side 'typeof EventEmitterAsyncResource' incorrectly extends base class static side 'typeof EventEmitter'.
  Types of property 'EventEmitterAsyncResource' are incompatible.
    Types of construct signatures are incompatible.
      Type 'new (options?: string | Options$1 | undefined) => EventEmitterAsyncResource' is not assignable to type 'new (options?: EventEmitterAsyncResourceOptions | undefined) => EventEmitterAsyncResource'.
        Construct signature return types 'EventEmitterAsyncResource' and 'EventEmitterAsyncResource' are incompatible.
          The types of 'asyncId' are incompatible between these types.
            Type '() => number' is not assignable to type 'number'.
Error: node_modules/tinypool/dist/index.d.ts(146,31): error TS2304: Cannot find name 'Worker'.

CI run: https://github.com/mshima/generator-jhipster/actions/runs/7835634934/job/21381450038?pr=914

@AriPerkkio
Copy link
Member

Could you set up a minimal reproduction for this? Or maybe solve this by not checking types of your dependencies by using skipLibCheck in tsconfig.json?

@mshima
Copy link
Author

mshima commented May 1, 2024

Disabling skipLibCheck because a single dependency is quite drastic.
We’ve switched to piscina.

@AriPerkkio
Copy link
Member

Similar issue from Piscina: piscinajs/piscina#426

Tinypool should apply similar changes as in piscinajs/piscina#433.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants