Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TxnGroup.sign_with_private_key should raise an error if the address is not one of the senders #43

Open
fergalwalsh opened this issue Oct 19, 2022 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@fergalwalsh
Copy link
Contributor

def sign_with_private_key(self, address, private_key):

If the address is not one of the senders we should raise an error.
This has tripped up some people who were passing a different address to the one used to generate the transactions but didn't get any error.

PS. Don't be tempted to refactor this to require only a private key and derive the address from that - that won't work for rekeyed accounts.

@fergalwalsh fergalwalsh added enhancement New feature or request good first issue Good for newcomers labels Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant